FIX VCD generation format for bus wire
Howdy,
Just started today, in my fork, modifying the VCD Export to accomodate correctly generated bus connections to the VCD format.
But couldn't figure out where i can get the connected bus width on the LA.
isBus() --> true/false. .. OK , where should I look to find the busproperties of the connected Pin on the AL .
Could you point me in the right direction ?
Thanks in advance .
P.S.
the commited https://github.com/fredcwbr/SimulIDE-dev.git is a WIP .. not ready... Working on it..
.h
QString &LAnalizer::VCDbinEncoder( int64_t value , int pin ) ;
int wireLength( int pin ) { return isbus ? m_channel[pin]->length() : 1 ; }
***
/*
*
* VDC binary encoder .,
* vl : int in ...
* sz : int in ..
* str : out ..
*
*/
QString &LAnalizer::VCDbinEncoder( int64_t value , int pin ) {
// VCDencoded bus vector
QString cdBus("b");
// Pin s(x) .. //
// int wirelength = ( isbus ? pin.length : 1 )
for( int i = wireLength( pin ) ; i > 0 ;) {
cdBus << ( value & (1<<(--i)) ? '1' : '0' );
}
cdBus << ' '; // mandatory space delimiter on VCD wire vector
return cdBus;
}
/* moved inside .h <<
int &LAnalizer::wireLength( pin )
*/
void LAnalizer::dumpData( QString fn ) {
/*
* https://en.wikipedia.org/wiki/Value_change_dump
* The identifier is composed of one or more printable ASCII characters
* from ! to ~ (decimal 33 to 126)
*
* if bus signals exist , they can be grouped (nested) in
* and vectored to the VCD , with bit representation
*
* these are conventionally kept short (i.e. one or two characters).
*
*
*/
*
*
*
*
*
*
/*
* if is_bus ., wirelength <= buslenght ,
* and coding VCD will be: 'b[D{*N}] S' ,
* where:
* N = Number of bits.,
* D = Bit value
* S = Channel symbol
*
* **** VERIFY ****
* Apparently simulide does get bus bits as absolute,
* so a remapped bus that has 8 bits starting from 8 [8..15] ,
* is registered on the analyzer as 16 bit values
* Since this analyzer enables supposedly any bitlength bus,
* IMHO if the channel should record the bits from 0 to buslength
* as presented to the channel to match whatever
* label was given independently of the wiring.,
*
* Conside the following examples: High order bit of a bus, [8..15] ,
* Value >>> should show <<<< shows...
* 0x01 b00000001 512
* 0x02 b00000010 1024
* 0x04 b00000100 2048
*
* wireLength <-- m_channel bus_width .<<<
*
*/
varDef += "$var wire " + QString(wireLength()) + " " + QString( identifiers[ch] ) + " " + name + " $end\n";
*
*
*
*
*
*
if ( !init ) {
/* ***** WIP ***** */
/* encode val to wirelength if > 1 to bn... VCD vector format .,
* where n is the bit image of the value, with wirelength size
*/
dumpVars += QString::number( initVal ) + identifiers[ch] + "\n"; // Add initial value
*
*
*
*
*
*
for ( sample_t sample : samples.values( time ) )
/* ***** WIP ***** */
/* encode val to wirelength if > 1 to bn... VCD vector format ., */
out << " " << VCDbinEncoder( sample.value , sample.channel ) << identifiers[sample.channel]; * * *
Hi.
There is nothing like "bus size" here.
You can find which is the highest bit registered in a Logic Analyzer channel, which is the effective bus width.
in LaChannel::stamp(), when m_busNodes is read you can keep track of bit numbers and get the highest value.
For example:
src/components/meters/lachannel.cpp
void LaChannel::stamp() // Called at Simulation Start
{
DataChannel::stamp();
m_analizer->conditonMet( m_channel, C_LOW );
addReading( 0 );
m_bitLength = 1;
if( m_pin->isBus() )
{
bool connected = m_pin->connector();
m_plotBase->display()->connectChannel( m_channel, connected );
for( eNode* node : m_busNodes ){
node->voltChangedCallback( this );
int bit = m_busNodes.key( node );
if( m_bitLength <= bit ) m_bitLength = bit+1;
}
}
}
Using LaChannel::bitLength() instead of LaChannel::length()
src/components/meters/lachannel.h
int bitLength() { return m_bitLength; }
private:
int m_bitLength;
It will give you bitLength = 6 in this case:
