A patch for changing from Qt5 to Qt6
Hi all
I have made a patch that updates from Qt5 to Qt6. It is here https://github.com/charonplutospace/SimulIDE-dev/tree/qt5-to-qt6
It is working fine and it would be nice to go from Qt5 to Qt6 as Qt5 begins to get old.
Thank you, I will have a look.
I take a look at work as it can be a fix for https://github.com/eeTools/SimulIDE-dev/issues/84
Looking at provided branch:
* 0d2a01b8 (charonplutospace/qt5-to-qt6) Qt5 to Qt6
* e94eaa9c Change from Qt5 to Qt6
* ac281041 Update Qt5 to Qt6
|\
| | * 681dbdc8 (HEAD -> qt5-to-qt6, origin/master, origin/HEAD, arcachofo/master, arcachofo/HEAD, albfan/master, albfan/HEAD, master) Merge pull request #83 from albfan/external-actions
| | |\
| | * | 63913b82 Merge pull request #82 from albfan/last-project-dir
| |/| |
| | | * 2f561b13 (albfan/external-actions, external-actions) External actions
| | |/
| |/|
| | * e69103d2 (albfan/last-project-dir, last-project-dir) Add Last Project bookmark
| |/
| * 38c1259b QemuDevice: Update files to "cpu only" implementation.
| * 7259cc6b Fix PIC CCP unit.
| * 248b92fb Merge pull request #80 from albfan/linked-switch
| |\
| * \ 4004490e Merge pull request #79 from albfan/i18n-es
| |\ \
| | * | 8b7dcff0 Fix es translation for Link
| | * | d78ca09b Fix es translation for show
| |/ /
| | * 95a0362f Implement linked value for switches
| |/
| * 47194c4f Merge pull request #76 from iammmmmmm/master
| |\
| | * 8720a39c Support for Simplified Chinese
| |/
| * 90555a20 ComponentList: fix compFolder;
| * 3d4f345d InstallItem: fix install button.
| * a8dcb47a Refactor Component shortcuts.
| * 89126010 Fix Create Comonent by shortcut position.
| * 1b913694 AvrWdt: fix WDP bits not saved.
| * 5d324b50 Update QemuDevice files to last changes.
* | ee432902 Rebase to latest master
|/
* 007ed782 (charonplutospace/master, charonplutospace/HEAD) Rotary Encoder: make Mouse press transparent out of knob.
Relevant commits are:
0d2a01b8 (charonplutospace/qt5-to-qt6) Qt5 to Qt6
e94eaa9c Change from Qt5 to Qt6
ac281041 Update Qt5 to Qt6ee432902 Rebase to latest master
and don't seem to be relevant here, just partial work and merges with upstream master.
My sugggestion to get this merged:
Open an issue on github
Open a PR
rebase all work:
From your branch qt5-to-qt6
git reset 681dbdc8
Mostly do it
Avoid if possible to change style and whitespace, or do in a separate commit
Just if helps I open https://github.com/eeTools/SimulIDE-dev/pull/90 with all those steps, while still crediting you as author Stefan
Don't worry, I'm already working in this.
Patch partially applied at this commit (and the previous one)
@stefanorsa thanks for the contribution, I added you as co-author of the commit.
Thank you.
This is the first time I commit/add something to a project on GitHub and also the first time I contribute to SimuIDE.
Questions.
1) Will my update from Qt5 to Qt6 be merged into master?
2) Do I need to make a merge request?
3) Do I need to do something else?
I just wanted to test developing SimuIDE, and I had Qt6 installed, so I thought it should just be a few updates. But it became very many.
Don't worry, you don't need to do anything else.
I just used your commits, removed some changes that are not related to the migration and made a new commit.
I didn't merged your commits, so I added you as co-author of this new commit:
https://github.com/eeTools/SimulIDE-dev/commit/52c9e1c9e764c1450ffb33461704ee74cb530c71
Have a look at your profile in Github and you will see it.
Hi @arcachofo
When I checkout the latest master, I got the errors shown in simulIDE-1.png It does not find QStringRef
I have the versions shown in simulIDE-2.png
Is I ask chat-gpt:
Yes — QStringRef is no longer part of Qt 6’s core API.
In Qt5 it lived in QtCore and you could use it to hold a non-owning substring reference, but in Qt6 it was removed from QtCore as part of the modernization of the string API.
What happened to QStringRef in Qt6?
-
Removed from QtCore:
QStringRefis not available by default in Qt6 anymore.
Qt5Compat module: For compatibility with existing Qt5 code, it was moved into the Qt5Compat module. You can still use it if you link against that module (e.g., Qt6::Core5Compat).
Recommended replacement: The preferred modern replacement is QStringView, which offers similar functionality (a non-owning view into a string) and is part of Qt6.
I got a lot of error and I fixed them one by one. This is why patch is so large. My patch works fine with the above versions.
Uploaded files:
When I checkout the latest master, I got the errors shown in simulIDE-1.png It does not find QStringRef
There is no QStringRef in proputils.h: https://github.com/eeTools/SimulIDE-dev/blob/master/src/gui/properties/proputils.h
Maybe there is some issue in your local repo?
I will check out a clean version tomorrow and check again.